Skip to content

Conversation

@Kielek
Copy link
Member

@Kielek Kielek commented Sep 5, 2025

Towards #2909

Changes

Change Enrich options to make it consistent with other Enrich methods.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@github-actions github-actions bot added the comp:instrumentation.aspnet Things related to OpenTelemetry.Instrumentation.AspNet label Sep 5, 2025
@Kielek Kielek marked this pull request as ready for review September 5, 2025 08:36
@Kielek Kielek requested a review from a team as a code owner September 5, 2025 08:36
@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.85%. Comparing base (b0d5cd4) to head (0ff0edf).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3070      +/-   ##
==========================================
+ Coverage   69.70%   69.85%   +0.15%     
==========================================
  Files         420      410      -10     
  Lines       16340    16228     -112     
==========================================
- Hits        11389    11336      -53     
+ Misses       4951     4892      -59     
Flag Coverage Δ
unittests-Instrumentation.AspNet 74.93% <100.00%> (ø)
unittests-Instrumentation.Cassandra ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...tion.AspNet/AspNetMetricsInstrumentationOptions.cs 100.00% <100.00%> (ø)
...umentation.AspNet/Implementation/HttpInListener.cs 80.41% <100.00%> (ø)

... and 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Martin Costello <[email protected]>
Copy link
Member

@alanwest alanwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Mostly aligns with what we did with ASP.NET Core.

@Kielek Kielek merged commit b324796 into open-telemetry:main Sep 8, 2025
61 checks passed
@Kielek Kielek deleted the aspnet-publicapi-metrics branch September 8, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:instrumentation.aspnet Things related to OpenTelemetry.Instrumentation.AspNet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants