[SqlClient] Remove non-functional netfx properties

[martincostello]

Changes

Remove members from the public API for SqlClient that do nothing on .NET Framework.

Copied and amended from #3072.

Merge requirement checklist

• CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
• Unit tests added/updated
• Appropriate CHANGELOG.md files updated for non-trivial changes
• Changes in public API reviewed (if applicable)

[Copilot]

Pull Request Overview

This PR removes non-functional public API properties from SqlClient instrumentation on .NET Framework to improve API clarity and consistency.

• Remove Enrich, Filter, and RecordException properties that were non-functional on .NET Framework
• Add conditional compilation directives to restrict these properties to .NET targets only
• Update test files to conditionally use the removed properties

Reviewed Changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
SqlClientTraceInstrumentationOptions.cs	Wrap non-functional properties with #if !NETFRAMEWORK directives
SqlClientDiagnosticListener.cs	Add conditional compilation for filter, enrich, and exception recording logic
Test files	Update tests to conditionally use removed properties based on target framework
PublicAPI files	Remove properties from general API surface and add framework-specific API files
CHANGELOG.md	Document breaking changes for removed properties
Common.prod.props	Add support for framework-specific public API files

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.99%. Comparing base (9d50b4b) to head (01285e1).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3079      +/-   ##
==========================================
+ Coverage   69.90%   69.99%   +0.09%     
==========================================
  Files         439      429      -10     
  Lines       16889    16805      -84     
==========================================
- Hits        11806    11763      -43     
+ Misses       5083     5042      -41     

Flag	Coverage Δ
unittests-Instrumentation.Cassandra	?
unittests-Instrumentation.SqlClient	87.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ient/Implementation/SqlClientDiagnosticListener.cs	88.31% <ø> (ø)
....SqlClient/SqlClientTraceInstrumentationOptions.cs	100.00% <ø> (ø)

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Kielek]

@rajkumar-rangaraj, @alanwest, what is your opinion here?
Can we ignore this? .NET Standard target has broader API than .NET Framework.

[rajkumar-rangaraj]

I'm fine with removing it. @alanwest Your thoughts?

[alanwest]

I'm unclear on what's being proposed. Are you asking whether we should remove Filter, Enrich, RecordException from the netstandard build as well?

[Kielek]

Only from .net framework, but it leads to warnings muted in this file.
Methods removed int his PR are noop in .net fx

[martincostello]

I think this is only needed until the next version ships to NuGet, then it can be deleted as the baseline in NuGet.org will match.

[alanwest]

Methods removed int his PR are noop in .net fx

Then yes it sounds like it's safe to keep the APIs in the netstandard build.

[martincostello]

I don't understand why the linter is complaining about the compatibility suppressions file, but also that file is auto-generated.

[Kielek]

I don't understand why the linter is complaining about the compatibility suppressions file, but also that file is auto-generated.

Known issue, you can modify it manually and make the linter happy. It should not be overwritten.

[martincostello]

I still don't understand exactly what it's complaining about though. It seems to be complaining there's some sort of non-ASCII space, but if I replace the spaces on the given line numbers by just pressing the spacebar then Git shows no changes.

[Kielek]

I still don't understand exactly what it's complaining about though. It seems to be complaining there's some sort of non-ASCII space, but if I replace the spaces on the given line numbers by just pressing the spacebar then Git shows no changes.

opentelemetry-dotnet-contrib/build/scripts/sanitycheck.py

Line 101 in 3f072fa

retval += sanitycheck('**/*.xml', allow_eol = (LF,), indent = 4)

4 spaces needed instead of 2?

[martincostello]

Oh, it wasn't clear to me from the workflow/job/step name that formatting other than EOL and non-ASCII was in scope.

[Kielek]

Discussion solved: #3079 (comment)
Merging.