Skip to content

Conversation

matt-hensley
Copy link
Contributor

@matt-hensley matt-hensley commented Sep 8, 2025

Fixes #
Design discussion issue #

Changes

Adopt new database span attributes for Redis driver.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@matt-hensley matt-hensley requested a review from a team as a code owner September 8, 2025 19:12
@github-actions github-actions bot added the comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis label Sep 8, 2025
@matt-hensley matt-hensley changed the title Redis attrs [Instrumentation.StackExchangeRedis] Adopt new database span attributes Sep 8, 2025
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.81%. Comparing base (af0d4b8) to head (6d4be95).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...mentation/RedisProfilerEntryToActivityConverter.cs 57.14% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3084      +/-   ##
==========================================
- Coverage   69.89%   69.81%   -0.09%     
==========================================
  Files         436      410      -26     
  Lines       16724    16268     -456     
==========================================
- Hits        11690    11357     -333     
+ Misses       5034     4911     -123     
Flag Coverage Δ
unittests-Extensions.Enrichment.Http ?
unittests-Instrumentation.Cassandra ?
unittests-Instrumentation.StackExchangeRedis 71.80% <75.00%> (+1.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...dis/StackExchangeRedisConnectionInstrumentation.cs 95.83% <100.00%> (+0.24%) ⬆️
...eRedis/StackExchangeRedisInstrumentationOptions.cs 100.00% <100.00%> (ø)
...mentation/RedisProfilerEntryToActivityConverter.cs 43.75% <57.14%> (+2.57%) ⬆️

... and 49 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Kielek Kielek merged commit dea5f9e into open-telemetry:main Sep 16, 2025
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:instrumentation.stackexchangeredis Things related to OpenTelemetry.Instrumentation.StackExchangeRedis

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants