Skip to content

Conversation

martincostello
Copy link
Member

@martincostello martincostello commented Sep 9, 2025

Changes

Replace usage of IWebHost with IHost, which is marked as obsolete in .NET 10.

Cherry-picked from #2822.

Documentation: https://learn.microsoft.com/en-us/dotnet/core/compatibility/aspnet-core/10/webhostbuilder-deprecated

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

Replace usage of `IWebHost` with `IHost`, which is marked as obsolete in .NET 10.
@github-actions github-actions bot added the comp:resources.aws Things related to OpenTelemetry.Resources.AWS label Sep 9, 2025
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.11%. Comparing base (2d3d158) to head (9ced990).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3096      +/-   ##
==========================================
+ Coverage   69.98%   70.11%   +0.13%     
==========================================
  Files         426      416      -10     
  Lines       16495    16444      -51     
==========================================
- Hits        11544    11530      -14     
+ Misses       4951     4914      -37     
Flag Coverage Δ
unittests-Instrumentation.Cassandra ?
unittests-Resources.AWS 74.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martincostello martincostello marked this pull request as ready for review September 9, 2025 16:53
@Copilot Copilot AI review requested due to automatic review settings September 9, 2025 16:53
@martincostello martincostello requested a review from a team as a code owner September 9, 2025 16:53
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the AWS ECS detector tests to replace the obsolete IWebHost with IHost for .NET 10 compatibility. This modernizes the test infrastructure while maintaining the same functionality.

  • Replace IWebHost with IHost in the mock ECS metadata endpoint
  • Update server configuration to use the new host builder pattern
  • Simplify disposal methods with expression-bodied syntax

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Kielek Kielek merged commit c8c5683 into open-telemetry:main Sep 10, 2025
68 checks passed
@martincostello martincostello deleted the remove-webhost-usage branch September 10, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:resources.aws Things related to OpenTelemetry.Resources.AWS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants