[Infra] Fix quotes in curl command for artifact download #3101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use double quotes so that environment variables are expanded.
There was a problem hiding this comment.
Pull Request Overview
Fixes shell variable expansion in a GitHub Actions workflow by changing single quotes to double quotes in a curl command's output path parameter, ensuring environment variables are properly expanded instead of being treated as literal strings.
- Fixed shell variable expansion issue in curl command for artifact download
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3101 +/- ##
==========================================
- Coverage 69.88% 69.75% -0.13%
==========================================
Files 420 430 +10
Lines 16566 16617 +51
==========================================
+ Hits 11577 11592 +15
- Misses 4989 5025 +36 Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
martincostello
added a commit
to martincostello/opentelemetry-dotnet
that referenced
this pull request
Sep 10, 2025
Use double quotes so the environment variables are expanded. See open-telemetry/opentelemetry-dotnet-contrib#3101.
evgenyfedorov2
approved these changes
Sep 10, 2025
RassK
approved these changes
Sep 10, 2025
Kielek
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Use double quotes so that environment variables are expanded.
Otherwise the files are downloaded to the literal path
${GITHUB_WORKSPACE}/artifacts/${GITHUB_REF_NAME}-packages.zip.Merge requirement checklist
Unit tests added/updatedAppropriateCHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)