-
Notifications
You must be signed in to change notification settings - Fork 354
Request to add Luke Zhang as an owner for AWS components. #3242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3242 +/- ##
==========================================
+ Coverage 66.37% 70.64% +4.26%
==========================================
Files 428 440 +12
Lines 16094 17213 +1119
==========================================
+ Hits 10683 12160 +1477
+ Misses 5411 5053 -358 Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
@srprash, @normj, @rypdal, @Oberon00, @muhammad-othman Could you please review and approve this PR? @lukeina2z would like to help you with maintaining these packages as an owner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would appreciate @lukeina2z help maintaining the AWS components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukeina2z, could you please also update all related README files?
Unfortunately, it is still manual task. If you think that it is worth to create some automation script, we can also accept it as separate PR.
opentelemetry-dotnet-contrib/src/OpenTelemetry.Instrumentation.AWS/README.md
Lines 3 to 6 in 8b5340d
| | Status | | | |
| | ----------- | --------- | | |
| | Stability | [Stable](../../README.md#stable) | | |
| | Code Owners | [@srprash](https://github.com/srprash), [@normj](https://github.com/normj) | |
ReadMe files updated. |
Changes
Please add Luke Zhang @lukeina2z as the owner of the AWS components.