Skip to content

[OpenTelemetry] Use config source generator #6587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+6 −10
Closed

[OpenTelemetry] Use config source generator #6587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b87812
[OpenTelemetry] Use config source generator
martincostello Oct 8, 2025
d2ebf07
[OpenTelemetry] Fix IDE0005 warning
martincostello Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions src/OpenTelemetry/Logs/ILogger/OpenTelemetryLoggingExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// SPDX-License-Identifier: Apache-2.0

using System.Diagnostics;
#if NET || EXPOSE_EXPERIMENTAL_FEATURES
#if EXPOSE_EXPERIMENTAL_FEATURES
using System.Diagnostics.CodeAnalysis;
#endif
using Microsoft.Extensions.DependencyInjection;
Expand Down Expand Up @@ -240,15 +240,6 @@ private static ILoggingBuilder AddOpenTelemetryInternal(
// Since currently this class only contains primitive properties this is OK. The top level properties are kept
// because the first generic argument of RegisterProviderOptions below is annotated with
// DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.All) so it will preserve everything on the OpenTelemetryLoggerOptions.
// But it would not work recursively into complex property values;
// This should be fully fixed with the introduction of Configuration binder source generator in .NET 8
// and then there should be a way to do this without any warnings.
// The correctness of these suppressions is verified by a test which validates that all properties of OpenTelemetryLoggerOptions
// are of a primitive type.
#if NET
[UnconditionalSuppressMessage("Trimming", "IL2026", Justification = "OpenTelemetryLoggerOptions contains only primitive properties.")]
[UnconditionalSuppressMessage("AOT", "IL3050", Justification = "OpenTelemetryLoggerOptions contains only primitive properties.")]
#endif
static void RegisterLoggerProviderOptions(IServiceCollection services)
{
LoggerProviderOptions.RegisterProviderOptions<OpenTelemetryLoggerOptions, OpenTelemetryLoggerProvider>(services);
Expand Down
5 changes: 5 additions & 0 deletions src/OpenTelemetry/OpenTelemetry.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
<NoWarn>$(NoWarn);CA1815</NoWarn> <!-- CA1815: Override equals and operator equals on value types - https://github.com/open-telemetry/opentelemetry-dotnet/issues/6278 -->
</PropertyGroup>

<!-- Enabled for native AoT compatibility in .NET 8+ -->
<PropertyGroup>
<EnableConfigurationBindingGenerator>true</EnableConfigurationBindingGenerator>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.Extensions.Diagnostics.Abstractions" />
<PackageReference Include="Microsoft.Extensions.Logging.Configuration" />
Expand Down
Loading