Skip to content

Conversation

@dmathieu
Copy link
Member

@dmathieu dmathieu commented May 19, 2025

Overview

Closes #6786

Added

Removed

Changed

Deprecated

Fixes

@dmathieu dmathieu added the Unlock Released Changelog PRs that need to change released section in CHANGELOG.md label May 19, 2025
@dmathieu dmathieu marked this pull request as ready for review May 19, 2025 08:15
Co-authored-by: Tyler Yahn <[email protected]>
@pellared
Copy link
Member

@dmathieu, @dashpole, just to double-check.
Is there something we should address for Prometheus exporter or is it good to go?
Related:

CC @ywwg @ArthurSens

pellared

This comment was marked as outdated.

@dashpole
Copy link
Contributor

@pellared i don't think we should log the warning. If a user is setting model.NameValidationScheme, they are already using a deprecated field. We should continue to support the legacy validation scheme until it is removed from the Prometheus library, or just keep it.

@dmathieu
Copy link
Member Author

We already removed the warning from the changelog. So we should be good here.
I believe semconv 1.32.0 is the only blocked for this release.

@pellared
Copy link
Member

@dashpole, what do you think of adding #5947 to the release? Do you think there would be issues if we merge it to in order to get some momentum? I am aware that the behavior is not in the spec yet, however it is an experimental exporter (both in the spec and the implementation).

@ArthurSens
Copy link
Member

@dashpole, what do you think of adding #5947 to the release? Do you think there would be issues if we merge it to in order to get some momentum? I am aware that the behavior is not in the spec yet, however it is an experimental exporter (both in the spec and the implementation).

Could we test the interaction with Prometheus receiver before making this decision? The PR you mention only adds new labels, but doesn't remove otel_scope_info, right? I suspect that all the otel_scope_[attributes] labels will become metric attributes, instead of scope attributes 😬

@pellared
Copy link
Member

pellared commented May 20, 2025

Could we test the interaction with Prometheus receiver before making this decision?

@ArthurSens, sure.

The PR you mention only adds new labels, but doesn't remove otel_scope_info, right?

Correct.

I suspect that all the otel_scope_[attributes] labels will become metric attributes, instead of scope attributes

I am pretty sure you are correct! However, TBH I have never seen scope attributes being used 😅

@dmathieu
Copy link
Member Author

This required testing makes me think we shouldn't include that PR into the release.

Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR description with new changelog entries 😉

@dmathieu dmathieu merged commit a85ae98 into open-telemetry:main May 21, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Unlock Released Changelog PRs that need to change released section in CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release v1.36.0/v0.58.0/v0.12.0 Checklist

6 participants