Simplify db getter and extractor hierarchy #12602
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
trask
force-pushed
the
simplify-db-getter-hierarchy
branch
from
51f114e to
62e11c9
Compare
18 tasks
trask
commented
Nov 11, 2024
Comment on lines
11
to
12
| @Deprecated | ||
| public interface DbClientCommonAttributesGetter<REQUEST> { |
There was a problem hiding this comment.
I returned this class to how it existed in the last release (v2.9.0), so the method removals in this class are ok if we merge before v2.10.0
trask
commented
Nov 11, 2024
| import io.opentelemetry.instrumentation.api.internal.SpanKeyProvider; | ||
| import javax.annotation.Nullable; | ||
|
|
||
| abstract class DbClientCommonAttributesExtractor< |
There was a problem hiding this comment.
this class was package-private, so I think ok to delete
|
Closing, I need to think about this more. I'm not sure that Also not sure where |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
DbClientCommonAttributesGetterandDbClientCommonAttributesExtractor, consolidating their functionality intoDbClientAttributesGetterandDbClientAttributesExtractor.