Fix exception with Java 8

[jeanbisutti]

See #13173 (comment)

cc @zeitlinger

[trask]

Fix exception with Java 8

I support the change, but what is the exception that's occurring? wondering we're missing a test?

[jeanbisutti]

It's a NumberFormatException, see #13173 (comment)

The exception is probably caught here:

opentelemetry-java-instrumentation/javaagent-tooling/src/main/java/io/opentelemetry/javaagent/tooling/AgentInstaller.java

Line 491 in 20be217

logger.log(SEVERE, "Failed to execute " + agentListener.getClass().getName(), e);

And the following shut down hook would not be registered:

opentelemetry-java-instrumentation/instrumentation/runtime-telemetry/runtime-telemetry-java8/javaagent/src/main/java/io/opentelemetry/instrumentation/javaagent/runtimemetrics/java8/Java8RuntimeMetricsInstaller.java

Line 31 in f312a64

.addShutdownHook(

[laurit]

@jeanbisutti you sure about this, Double.parseDouble("1.8") works just fine. Perhaps you are confusing it with some earlier version of the code that might have used Integer.parseInt(System.getProperty("java.specification.version"));?

[jeanbisutti]

@laurit Yes, I had Integer.parseInt(System.getProperty("java.specification.version") in mind