feat: Add support for thrift #13735
feat: Add support for thrift #13735
Conversation
|
hi @YaoYingLong, I don't think anyone can review this in the current form:
|
|
Firstly this PR targets v1.31.x, it is unlikely that we'll be making any more releases for the 1.x series. Please target your PR agains main branch. Secondly this PR contains a ton of code that seems to be either generated or duplicated. Consider generating code during the build and sharing the test classes. As @trask pointed out this PR currently contains too much code. |
Due to the differences between versions of Thrift, most of the code here, including the duplicated code, consists of test cases for versions with significant differences. The actual agent code is only for thrift-0.7.0, thrift-0.9.1, and thrift-common, so the amount of code is actually not large. |
I will first try to modify this PR to target the main branch. The large amount of code that appears to be generated or duplicated is only included for convenience in testing. After the modification, this part of the code will be removed. Sharing test classes is somewhat challenging due to the significant differences between Thrift versions. Even within the same class, the imported class paths are different, making it difficult to share. The reason why the code looks extensive is that a large number of test cases have been written, including for versions with significant differences. Therefore, most of the code consists of test cases, while the actual core code is very minimal. In subsequent submissions, I can retain only the test cases for Thrift-0.7.0 and Thrift-0.9.1 versions. |
Fix：#1573