add Nullaway to instrumentation API incubator #14459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitlinger
force-pushed
the
nullaway-inst-api-inucubator
branch
from
c3c5f29 to
26e4e73
Compare
zeitlinger
commented
Sep 17, 2025
| private final String loggingSpanIdKey; | ||
| private final String loggingTraceFlagsKey; | ||
|
|
||
| interface ValueProvider<T> { |
There was a problem hiding this comment.
simply adding @Nullable to the generic arg didn't work
|
🔧 The result from spotlessApply was committed to the PR branch. |
|
@laurit please take a look |
laurit
reviewed
Sep 26, 2025
...java/io/opentelemetry/instrumentation/api/incubator/instrumenter/InstrumenterCustomizer.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Sep 26, 2025
...elemetry/instrumentation/api/incubator/instrumenter/internal/InstrumenterCustomizerImpl.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Sep 26, 2025
| private final String loggingSpanIdKey; | ||
| private final String loggingTraceFlagsKey; | ||
|
|
||
| interface ValueProvider<T> { |
There was a problem hiding this comment.
is this needed because the return type of java.util.function.Function is considered to be non-nullable?
zeitlinger
force-pushed
the
nullaway-inst-api-inucubator
branch
from
53f0453 to
0bbe11c
Compare
laurit
approved these changes
Sep 26, 2025
trask
reviewed
Sep 26, 2025
| abstract String getPath(); | ||
|
|
||
| public boolean matches(Integer port, Supplier<String> pathSupplier) { | ||
| public boolean matches(@Nullable Integer port, @Nullable Supplier<String> pathSupplier) { |
There was a problem hiding this comment.
it looks like null is never passed in here (need to also remove @Nullable from calling method param)
Suggested change
| public boolean matches(@Nullable Integer port, @Nullable Supplier<String> pathSupplier) { | |
| public boolean matches(@Nullable Integer port, Supplier<String> pathSupplier) { |
There was a problem hiding this comment.
- pathSupplier is
nullin - port is
nullin (a couple of layers, see screenshot)
There was a problem hiding this comment.
ah, I see, how about zeitlinger#7?
An option for less Nullable
|
🔧 The result from spotlessApply was committed to the PR branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.