make opentelemetry-* indy-ready #14695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🔧 The result from spotlessApply was committed to the PR branch. |
…elemetry-java-instrumentation into indy-opentelemetry-api
SylvainJuge
commented
Sep 18, 2025
| // Every usage of @Advice.Origin Method is replaced with a call to Class.getMethod, copy it | ||
| // to local variable so that there would be only one call to Class.getMethod. | ||
| method = originMethod; | ||
| public static class WithSpanAdviceScope { |
There was a problem hiding this comment.
[for reviewer] using a different name here was required to pass checkstyle which complains about multiple AdviceScope classes in the same file.
…nstrumentation into indy-opentelemetry-api
...io/opentelemetry/javaagent/instrumentation/extensionannotations/WithSpanInstrumentation.java
Show resolved
Hide resolved
LikeTheSalad
approved these changes
Sep 25, 2025
laurit
reviewed
Sep 26, 2025
...emetry/javaagent/instrumentation/opentelemetryapi/ContextStorageWrappersInstrumentation.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Sep 26, 2025
...io/opentelemetry/javaagent/instrumentation/extensionannotations/WithSpanInstrumentation.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Sep 26, 2025
...opentelemetry/javaagent/instrumentation/extensionkotlin/ContextExtensionInstrumentation.java
Outdated
Show resolved
Hide resolved
…nstrumentation into indy-opentelemetry-api
…elemetry-java-instrumentation into indy-opentelemetry-api
laurit
reviewed
Sep 26, 2025
Comment on lines
116
to
121
| Span result = originalResult; | ||
|
|
||
| if (applicationSpan != null) { | ||
| result = applicationSpan; | ||
| } | ||
| return result; |
There was a problem hiding this comment.
could also convert to one liner
laurit
reviewed
Sep 26, 2025
Comment on lines
78
to
83
| Context result = originalResult; | ||
|
|
||
| if (newApplicationContext != null) { | ||
| result = newApplicationContext; | ||
| } | ||
| return result; |
There was a problem hiding this comment.
could also convert to one liner
laurit
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #13031 for all the
opentelemetry-*instrumentation modules.