Skip to content

Improve dubbo network type assertion #14717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 24, 2025
Merged

Improve dubbo network type assertion #14717

merged 3 commits into from
Sep 24, 2025

Conversation

@laurit
Copy link
Contributor

@laurit laurit commented Sep 19, 2025

instead of

k.satisfiesAnyOf(
  val -> assertThat(val).isNull(),
  val -> assertThat(val).isEqualTo("ipv4"),
  val -> assertThat(val).isEqualTo("ipv6")))),

verify that value is either ipv4 or ipv6 for latest deps or null for non-latest

@laurit laurit requested a review from a team as a code owner September 19, 2025 10:46
@laurit
Copy link
Contributor Author

laurit commented Sep 19, 2025

@steverao could you help with this, for me locally AbstractDubboTraceChainTest.testDubboChainInJvm fails even without these changes

@laurit laurit merged commit 5c027b5 into open-telemetry:main Sep 24, 2025
89 checks passed
mznet pushed a commit to mznet/opentelemetry-java-instrumentation that referenced this pull request Sep 26, 2025
@laurit @steverao @mznet
Improve dubbo network type assertion (open-telemetry#14717)
cdfeb89 
Co-authored-by: Steve Rao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zeitlinger zeitlinger zeitlinger approved these changes

@steverao steverao steverao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@laurit @zeitlinger @steverao