Skip to content

Catch exception when reactor netty response is not available #14778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 24, 2025
Merged

Catch exception when reactor netty response is not available #14778

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4ed2c42
Catch exception when reactor netty response is not available
laurit Sep 24, 2025
54182c3
remove unused import
laurit Sep 24, 2025
9e0e97e
Apply suggestion from @SylvainJuge
laurit Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions ...y/javaagent/instrumentation/reactornetty/v1_0/ReactorNettyHttpClientAttributesGetter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@

package io.opentelemetry.javaagent.instrumentation.reactornetty.v1_0;

import static java.util.Collections.emptyList;

import io.netty.handler.codec.http.HttpVersion;
import io.opentelemetry.instrumentation.api.semconv.http.HttpClientAttributesGetter;
import java.net.InetSocketAddress;
Expand All @@ -30,19 +32,34 @@ public String getHttpRequestMethod(HttpClientRequest request) {

@Override
public List<String> getHttpRequestHeader(HttpClientRequest request, String name) {
return request.requestHeaders().getAll(name);
try {
return request.requestHeaders().getAll(name);
} catch (IllegalStateException exception) {
// response not available
return emptyList();
}
}

@Override
public Integer getHttpResponseStatusCode(
HttpClientRequest request, HttpClientResponse response, @Nullable Throwable error) {
return response.status().code();
try {
return response.status().code();
} catch (IllegalStateException exception) {
// response not available
return null;
}
}

@Override
public List<String> getHttpResponseHeader(
HttpClientRequest request, HttpClientResponse response, String name) {
return response.responseHeaders().getAll(name);
try {
return response.responseHeaders().getAll(name);
} catch (IllegalStateException exception) {
// response not available
return emptyList();
}
}

@Nullable
Expand Down