Skip to content

Conversation

@jaydeluca
Copy link
Member

Fixes #14818

The .github/scripts/use-cla-approved-bot.sh script was being run from a differnt directory from where the benchmark git operations are being done (./gh-pages), so moving the config commands directly into the script that runs in that other directory

Fixes the error:

Run git add benchmark-overhead/results
Author identity unknown

*** Please tell me who you are.

Run

  git config --global user.email "[email protected]"
  git config --global user.name "Your Name"

to set your account's default identity.
Omit --global to set the identity only in this repository.

fatal: empty ident name (for <runner@runnervm3ublj.3xvpnnmqe0pufide3cozgi5fjc.cx.internal.cloudapp.net>) not allowed
Error: Process completed with exit code 128.

@jaydeluca jaydeluca requested a review from a team as a code owner September 27, 2025 09:59
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you keep the existing step (with your new implementation) and add a comment why not using the script? (So I don't accidentally "fix" it later)

run: rsync -avv benchmark-overhead/results/ gh-pages/benchmark-overhead/results/ && rm -rf benchmark-overhead/results

- name: Use CLA approved bot
run: .github/scripts/use-cla-approved-bot.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this would work?

Suggested change
run: .github/scripts/use-cla-approved-bot.sh
working-directory: ./gh-pages

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe it needs to be

run: ../.github/scripts/use-cla-approved-bot.sh
working-directory: ./gh-pages

@trask trask enabled auto-merge (squash) September 29, 2025 17:28
@trask trask merged commit 5ace973 into open-telemetry:main Sep 29, 2025
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Workflow failed: Overhead benchmark (daily) (#1281)

3 participants