-
Notifications
You must be signed in to change notification settings - Fork 916
Run CodeQL on PRs #7070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Run CodeQL on PRs #7070
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0015800
Run CodeQL on PRs
trask 3858e7c
and benchmarks branch
trask 5ed62c4
no-daemon
trask 0ae4605
fix
trask d408830
hashes
trask 328cd4f
Merge remote-tracking branch 'upstream/main' into codeql
trask 48cb63b
Apply suggestions from code review
trask File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| name: CodeQL | ||
|
|
||
| on: | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| - release/* | ||
| - benchmarks | ||
| push: | ||
| branches: | ||
| - main | ||
| - release/* | ||
| - benchmarks | ||
| schedule: | ||
| - cron: "29 13 * * 2" # weekly at 13:29 UTC on Tuesday | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| analyze: | ||
| permissions: | ||
| contents: read | ||
| actions: read # for github/codeql-action/init to get workflow details | ||
| security-events: write # for github/codeql-action/analyze to upload SARIF results | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
|
|
||
| - name: Set up Java 17 | ||
| uses: actions/setup-java@3a4f6e1af504cf6a31855fa899c6aa5355ba6c12 # v4.7.0 | ||
| with: | ||
| distribution: temurin | ||
| java-version: 17 | ||
|
|
||
| - name: Set up gradle | ||
| uses: gradle/actions/setup-gradle@94baf225fe0a508e581a564467443d0e2379123b # v4.3.0 | ||
|
|
||
| - name: Initialize CodeQL | ||
| uses: github/codeql-action/init@dd746615b3b9d728a6a37ca2045b68ca76d4841a # v3.28.8 | ||
| with: | ||
| languages: java, actions | ||
| # using "latest" helps to keep up with the latest Kotlin support | ||
| # see https://github.com/github/codeql-action/issues/1555#issuecomment-1452228433 | ||
| tools: latest | ||
|
|
||
| - name: Assemble | ||
| # --no-build-cache is required for codeql to analyze all modules | ||
| # --no-daemon is required for codeql to observe the compilation | ||
| # (see https://docs.github.com/en/code-security/codeql-cli/getting-started-with-the-codeql-cli/preparing-your-code-for-codeql-analysis#specifying-build-commands) | ||
| run: ./gradlew assemble --no-build-cache --no-daemon | ||
|
|
||
| - name: Perform CodeQL analysis | ||
| uses: github/codeql-action/analyze@dd746615b3b9d728a6a37ca2045b68ca76d4841a # v3.28.8 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redundant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my understanding is
contents: readso I think I can remove them, let me try this in instrumentation repo first also...
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this didn't work, see explanation in open-telemetry/opentelemetry-java-instrumentation#13247
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for trying.