Skip to content

Conversation

@trask
Copy link
Member

@trask trask commented Feb 9, 2025

No description provided.

@trask trask requested a review from a team as a code owner February 9, 2025 16:13
@codecov
Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (0644948) to head (551a764).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7090      +/-   ##
============================================
+ Coverage     89.85%   89.86%   +0.01%     
  Complexity     6613     6613              
============================================
  Files           740      740              
  Lines         19991    19991              
  Branches       1966     1966              
============================================
+ Hits          17962    17964       +2     
+ Misses         1438     1437       -1     
+ Partials        591      590       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.



val DEPENDENCIES = listOf(
"org.junit.jupiter:junit-jupiter-api:5.11.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we follow the armeria pattern and explicitly add dependency versions here for each of the junit components we use? I.e.:

"org.junit.jupiter:junit-jupiter-api:${junitVersion}",
"org.junit.jupiter:junit-jupiter-params:${junitVersion}",
"org.junit.jupiter:junit-jupiter-pioneer:${junitVersion}",

If we can, we should try to retain the pattern of establishing all dependency versions here and not letting the junit dependency version leak into otel-java-conventions.gradle.kts.

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jack-berg jack-berg merged commit 517893e into open-telemetry:main Feb 10, 2025
28 checks passed
@trask trask deleted the fossa branch October 20, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants