Skip to content

Conversation

@trask
Copy link
Member

@trask trask commented Feb 10, 2025

along with selective reordering and pruning, let me know if you have any preferences

@trask trask requested a review from a team as a code owner February 10, 2025 18:57
@codecov
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.98%. Comparing base (00b61a2) to head (319b8b1).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7094   +/-   ##
=========================================
  Coverage     89.98%   89.98%           
  Complexity     6685     6685           
=========================================
  Files           749      749           
  Lines         20191    20191           
  Branches       1977     1977           
=========================================
  Hits          18168    18168           
  Misses         1431     1431           
  Partials        592      592           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@jack-berg jack-berg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:

Screenshot 2025-02-11 at 2 59 16 PM

After:

Screenshot 2025-02-11 at 2 59 12 PM

Lot of real estate for security related things, but seems ok.

@trask
Copy link
Member Author

trask commented Feb 11, 2025

I could do without the best practices badge, in retrospect I don't think that one is too meaningful (and now I know how to add clomonitor exemptions, and we can document in the exemption that we have the badge but we just don't display it on the readme)

@trask trask marked this pull request as draft February 12, 2025 23:01
@trask
Copy link
Member Author

trask commented Feb 12, 2025

(hold on merging, I probably need to update the FOSSA link again as I move us over to CNCF's FOSSA enterprise account)

@jack-berg
Copy link
Member

Just checking in on this

@trask trask marked this pull request as ready for review April 10, 2025 15:39
@trask
Copy link
Member Author

trask commented Apr 11, 2025

@jack-berg this is good to go now

@jack-berg jack-berg merged commit e695b66 into open-telemetry:main Apr 11, 2025
28 checks passed
@trask trask deleted the fossa-badges branch October 20, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants