Skip to content

Conversation

@trask
Copy link
Member

@trask trask commented Feb 17, 2025

Resolves #7075

Please merge #7095 first, I'll need to rebase this and resolve a merge conflict between the two afterwards.

@trask trask marked this pull request as ready for review February 17, 2025 03:13
@trask trask requested a review from a team as a code owner February 17, 2025 03:13
@codecov
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.87%. Comparing base (fe73fb7) to head (dc751da).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7115   +/-   ##
=========================================
  Coverage     89.87%   89.87%           
  Complexity     6614     6614           
=========================================
  Files           740      740           
  Lines         19991    19991           
  Branches       1966     1966           
=========================================
  Hits          17966    17966           
  Misses         1436     1436           
  Partials        589      589           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jack-berg
Copy link
Member

Please merge #7095 first, I'll need to rebase this and resolve a merge conflict between the two afterwards.

Done

Comment on lines +101 to +103
- `NVD_API_KEY` - stored in OpenTelemetry-Java 1Password
- Generated at https://nvd.nist.gov/developers/request-an-api-key
- Key is associated with [@trask](https://github.com/trask)'s gmail address
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the secret to this repo already

@jack-berg jack-berg merged commit 5879f48 into open-telemetry:main Feb 19, 2025
27 checks passed
@trask trask deleted the owasp branch October 20, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OWASP workflow is failing

3 participants