Skip to content

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Nov 21, 2025

Which problem is this PR solving?

req.abort() is deprecated, but it is used in a couple tests.

Fixes # N/A

Short description of the changes

This commit replaces abort() with destroy() as the deprecation suggests.

Type of change

None of these. Replaces a deprecated API.

How Has This Been Tested?

  • Test suite.

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@cjihrig cjihrig requested a review from a team as a code owner November 21, 2025 15:31
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.40%. Comparing base (141d009) to head (32cfb2d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6149   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files         317      317           
  Lines        9427     9427           
  Branches     2178     2178           
=======================================
  Hits         8994     8994           
  Misses        433      433           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maryliag
Copy link
Contributor

Thank you

@maryliag maryliag added this pull request to the merge queue Nov 24, 2025
Merged via the queue into open-telemetry:main with commit 8ff6b76 Nov 24, 2025
27 checks passed
@otelbot
Copy link
Contributor

otelbot bot commented Nov 24, 2025

Thank you for your contribution @cjihrig! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

@cjihrig cjihrig deleted the deprecated-abort branch November 24, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants