fix: Handle missing config in middleware when OTEL_SDK_DISABLED=true#2231
Open
hannahramadan wants to merge 1 commit intoopen-telemetry:mainfrom
Open
fix: Handle missing config in middleware when OTEL_SDK_DISABLED=true#2231hannahramadan wants to merge 1 commit intoopen-telemetry:mainfrom
hannahramadan wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
hannahramadan
requested review from
a team,
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
kaylareopelle,
mwear,
plantfansam,
robbkidd,
robertlaurin,
simi and
xuan-cao-swi
as code owners
hannahramadan
changed the title
Contributor
|
@hannahramadan is this not something that should be handled in Base? Also, any chance that you could add some test coverage for this? |
arielvalentin
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
OTEL_SDK_DISABLED=true, the SDK skips configuration and Rack instrumentation's config is an empty hash. When attempting to access nil values, aNoMethodErrorwas raised.Instrumentation was already handling this scenario on line 19 and line 31, which use
Array()for similar config values. That pattern was copied as the fix for this issue.All three dup, old, and stable files were updated.
closes #2230