-
Notifications
You must be signed in to change notification settings - Fork 601
docs: logs enrichment #3266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: logs enrichment #3266
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3266 +/- ##
=====================================
Coverage 80.7% 80.7%
=====================================
Files 129 129
Lines 23210 23210
=====================================
Hits 18748 18748
Misses 4462 4462 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I haven't seen any changelog entry for examples, but do let me know if I should add something to the changelog. |
|
Hey @stefanobaghino thanks for raising this! |
Thanks for pointing that out to me, formatting addressed in a446807 (and I checked again after addressing @cijothomas's comments). |
1b96b67 to
cd75428
Compare
cd75428 to
8da1410
Compare
examples/logs-advanced/Cargo.toml
Outdated
| name = "logs-advanced" | ||
| path = "src/main.rs" | ||
| bench = false | ||
| required-features = ["spec_unstable_logs_enabled"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we just merged a PR that removes this feature flag. The feature is stable and now does not require feature flags. Could you update to reflect it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #2759
Changes
The approach suggested here by @scottgerring has been implemented:
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes