-
Notifications
You must be signed in to change notification settings - Fork 933
[Blocked] Add empty value attribute #4595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
026fad1
Add empty value to attribute
pellared 1831164
Update changelog
pellared 82e8913
toc
pellared 9cab0c4
fix status
pellared 85db60a
Remove the note that extending attributes is a breaking change
pellared eaea1ea
Update CHANGELOG.md
pellared 25c2c25
Update specification/common/attribute-type-mapping.md
pellared d9ac9f7
Merge branch 'main' into empty-attr
pellared 75b22ad
Merge branch 'main' into empty-attr
pellared c540098
revert breaking change note
pellared 05fa307
Merge branch 'main' into empty-attr
pellared File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to start with proto changes and replace comments like https://github.com/open-telemetry/opentelemetry-proto/blob/be5d58470429d0255ffdd49491f0815a3a63d6ef/opentelemetry/proto/trace/v1/trace.proto#L209-L213
(as per https://github.com/open-telemetry/opentelemetry-specification/blob/main/oteps/4485-extending-attributes-to-support-complex-values.md#proto)
we probably need to replace it with comment that they are going to be allowed in 6 months
opentelemetry-specification/oteps/4485-extending-attributes-to-support-complex-values.md
Lines 111 to 112 in 8aa1d27
Or, at least, leave a note here that complex attributes are coming and their support is in development, nobody should stabilize them in the next 6 month.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this is an orthogonal PR given the changes of https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/common/README.md#attribute are marked with Development status.
Moreover, this PR does not make the existing comment invalid and should block this PR.
Therefore, I think a PR in proto repo can be done in parallel.
I am not sure how we want to update the comment in proto repo as of today.
Are you able to help with it?
EDIT: I tried to come up with a PR in the proto repo. PTAL:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in the SIG meeting, we agreed to reintroduce this "note" in this PR, since it’s clearer to handle the broader change in a separate PR. That separate PR will:
This PR will be blocked until that separate PR is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created #4602 for tracking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lmolkova, can you please block this PR (request changes) with e.g. following comment:
so that it is not accidentally merged?