-
Notifications
You must be signed in to change notification settings - Fork 278
Add faas instance entity #2575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add faas instance entity #2575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any problems with this change. We asked the author to implement this in one of the languages for review purposes and be prepared to implement it in a couple other languages if it's approved.
|
@tylerbenson thanks for feedback, see open-telemetry/opentelemetry-dotnet-contrib#3087 for the update done to the dotnet implementation. Key thing being scope is naming update rather new attributes. I would suggest looking to stabilise or atleast moving to beta/rc stability for atleast the function & instance namespaces that implementations can be updated in bulk. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
93e0b20 to
f2023d4
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
I will close this PR as there's no current SIG active for FaaS and no clear code owners to review/work on a migration path for this. |
Changes
Enable instance to be able to be an entity which required rename of the attribute.
By having instance as an entity we are following the pattern in other namespaces, we can have the faas entity describing the function whereas the instance describes an instance of when said function has been run.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]