Skip to content

Conversation

@thompson-tomo
Copy link
Contributor

@thompson-tomo thompson-tomo commented Jul 31, 2025

Changes

Enable instance to be able to be an entity which required rename of the attribute.

By having instance as an entity we are following the pattern in other namespaces, we can have the faas entity describing the function whereas the instance describes an instance of when said function has been run.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

@thompson-tomo thompson-tomo requested review from a team as code owners July 31, 2025 03:23
@thompson-tomo thompson-tomo changed the title Add instance entity Add faas instance entity Aug 5, 2025
Copy link
Member

@tylerbenson tylerbenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any problems with this change. We asked the author to implement this in one of the languages for review purposes and be prepared to implement it in a couple other languages if it's approved.

@thompson-tomo
Copy link
Contributor Author

@tylerbenson thanks for feedback, see open-telemetry/opentelemetry-dotnet-contrib#3087 for the update done to the dotnet implementation. Key thing being scope is naming update rather new attributes.

I would suggest looking to stabilise or atleast moving to beta/rc stability for atleast the function & instance namespaces that implementations can be updated in bulk.

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 25, 2025
@thompson-tomo thompson-tomo force-pushed the feature/#2393_SplitInstanceOut branch from 93e0b20 to f2023d4 Compare September 26, 2025 06:28
@github-actions github-actions bot removed the Stale label Sep 27, 2025
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 13, 2025
@joaopgrassi
Copy link
Member

I will close this PR as there's no current SIG active for FaaS and no clear code owners to review/work on a migration path for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants