Skip to content

Conversation

IOhacker
Copy link
Contributor

@IOhacker IOhacker commented Oct 2, 2025

Description

WEB-336: Fix translation view inactive charges button for Savings

Related issues and discussion

#{Issue Number}

Screenshots, if any

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • If you have multiple commits please combine them into one commit by squashing them.

  • Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

Summary by CodeRabbit

  • Style
    • Updated the charges tab header button label to a single-line “View Inactive Charges,” replacing the previous split-line text. This improves readability, consistency, and reduces awkward wrapping in tighter layouts.
    • Visual/wording-only update; no functional or behavioral changes to interactions or data.

Copy link

coderabbitai bot commented Oct 2, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

A single HTML template in the savings account charges tab was updated: the else branch of a ternary now passes the single-line string 'View Inactive Charges' to viewAllChargeButtons instead of a multi-line string. No other logic or control flow changes.

Changes

Cohort / File(s) Summary
UI copy update in charges tab template
src/app/savings/savings-account-view/charges-tab/charges-tab.component.html
Replaced multi-line string in ternary else with single-line 'View Inactive Charges' passed to viewAllChargeButtons.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • AlejandroED21
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5133d9e and 35f6f7b.

📒 Files selected for processing (1)
  • src/app/savings/savings-account-view/charges-tab/charges-tab.component.html (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Collaborator

@AlejandroED21 AlejandroED21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlejandroED21 AlejandroED21 merged commit 2462ea5 into openMF:dev Oct 2, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants