WEB-322: Re-aging: Interest handling configuration as optional parameter

[alberto-art3ch]

Description

Re-aging: Interest handling configuration as optional parameter

Related issues and discussion
WEB-322

Screenshots

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• If you have multiple commits please combine them into one commit by squashing them.

• Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

Summary by CodeRabbit

• Bug Fixes
  • Updated the Loan Re‑aging form so the “Re‑age Interest Handling” field is no longer required. This reduces unnecessary validation errors and allows form submission without selecting a value for that field, improving form completion flow.

[coderabbitai]

Walkthrough

The LoanReagingComponent’s form initialization was adjusted by removing the Validators.required constraint from the reAgeInterestHandling control, making this field optional in the createReagingLoanForm method.

Changes

Cohort / File(s)	Summary
Loan re-aging form validation src/app/loans/loans-view/loan-account-actions/loan-reaging/loan-reaging.component.ts	Removed Validators.required from the reAgeInterestHandling form control in createReagingLoanForm, making the control optional.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

• WEB-322: Re-aging: Interest handling configuration with id #2704 — Also modifies reAgeInterestHandling in loan-reaging.component (template option switched to use id), indicating related handling of the same control.

Suggested reviewers

• steinwinde

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title accurately reflects the key change of making the interest handling configuration optional in the re-aging feature and includes the relevant ticket reference without extraneous details.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/app/loans/loans-view/loan-account-actions/loan-reaging/loan-reaging.component.ts (1)

73-75: Confirm backend accepts optional reAgeInterestHandling

• Removal of Validators.required correctly makes the field optional; verify your backend endpoint accepts a missing or null reAgeInterestHandling.
• Optional: initialize with this.reAgeInterestHandlingOptions?.[0] ?? null to explicitly handle empty arrays.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6b0c9ca and 8ce8bc5.

📒 Files selected for processing (1)

• src/app/loans/loans-view/loan-account-actions/loan-reaging/loan-reaging.component.ts (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

src/app/**

⚙️ CodeRabbit configuration file

src/app/**: For Angular code: verify component separation, trackBy on *ngFor,
strict type safety, and clean observable patterns.

Files:

• src/app/loans/loans-view/loan-account-actions/loan-reaging/loan-reaging.component.ts

[steinwinde]

LGTM