Write scientific defaults upon close (Iteration::close or Series::close) #1834
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| template <typename Child> | ||
| void ScientificDefaults<Child>::addDefaults() |
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
| } | ||
|
|
||
| template <typename Child> | ||
| void ScientificDefaults<Child>::addDefaults() |
Check warning
Code scanning / CodeQL
Poorly documented large function Warning
| // for (size_t i = 0; i < udims.size(); ++i) | ||
| // { | ||
| // res[7 * i] = 1; | ||
| // } |
Check notice
Code scanning / CodeQL
Commented-out code Note
| // TODO: unitSI | ||
| // REQUIRE(r["x"].numAttributes() == 0); | ||
| // REQUIRE(r["y"].numAttributes() == 0); | ||
| // REQUIRE(r["z"].numAttributes() == 0); |
Check notice
Code scanning / CodeQL
Commented-out code Note test
|
TODO: Move this check into finalize, maybe only print a warning throw std::runtime_error(
"A Record can not be written without any contained "
"RecordComponents: " +
name); |
|
@franzpoeschel is this for 0.18.0? :) |
Yup, this is still under development |
Moved to finalize(), degraded to warning
franzpoeschel
force-pushed
the
defaults-upon-close
branch
from
0f1d020 to
2115ede
Compare
prep for reading
franzpoeschel
force-pushed
the
defaults-upon-close
branch
from
941b3fd to
03b283b
Compare
| } | ||
|
|
||
| template <typename... Args> | ||
| void operator()(Args &&...) |
Check notice
Code scanning / CodeQL
Unused static variable Note
| } | ||
|
|
||
| template <typename... Args> | ||
| void operator()(Args &&...) |
Check notice
Code scanning / CodeQL
Unused local variable Note
| { | ||
| } |
Check notice
Code scanning / CodeQL
Empty branch of conditional Note
2 participants
Close #1439
This PR focuses on Iteration-level attributes (including attributes included below Iteration level)
Needed for introducing a synchronous mode
TODO:
finalize()method publically, so users can request openPMD to set defaults now