attempt to cache the index and avoid some indexOf() call #1860
Merged
franzpoeschel merged 9 commits intoopenPMD:devfrom Mar 10, 2026
Merged
attempt to cache the index and avoid some indexOf() call #1860franzpoeschel merged 9 commits intoopenPMD:devfrom
franzpoeschel merged 9 commits intoopenPMD:devfrom
Conversation
…xOf() call for iterations
for more information, see https://pre-commit.ci
franzpoeschel
requested changes
Mar 9, 2026
| * If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| #include "openPMD/Iteration.hpp" // needed for index caching in operator[] |
Contributor
There was a problem hiding this comment.
Pre-declaring should be fine, but note my comment below, this entire logic is better placed in linkHierarchy()
Contributor
Author
There was a problem hiding this comment.
oh, didn't know, let me see
Contributor
Author
There was a problem hiding this comment.
I think I don't know linkHierarchy() enough to decide. It looks like a big change to me. Maybe merge this pull request and you make a new pull request and work on it?
Contributor
There was a problem hiding this comment.
I put the logic into GenerationPolicy now, linkHierarchy was not adequate upon closer looking. With this, I think we can merge.
franzpoeschel
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hope this resolves issue #1859