Integrate Virtual Microscope with centralized SettingsController and ObjectiveController#146
Draft
Integrate Virtual Microscope with centralized SettingsController and ObjectiveController#146
Conversation
Co-authored-by: beniroquai <4345528+beniroquai@users.noreply.github.com>
…eatures Co-authored-by: beniroquai <4345528+beniroquai@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Virtual Microscope Improvements
Enhance Virtual Microscope Manager with comprehensive simulation capabilities and API endpoints
Aug 23, 2025
Collaborator
|
@copilot some remarks:
|
…ngsController and ObjectiveController Co-authored-by: beniroquai <4345528+beniroquai@users.noreply.github.com>
Contributor
Author
I've implemented all the requested changes in commit 5821e27: 1. setExposureAndGain merged into SettingsController:
2. switchObjective integrated with ObjectiveController:
3. Drift now applies relative increments:
The VirtualMicroscopeManager now has |
Copilot
AI
changed the title
Enhance Virtual Microscope Manager with comprehensive simulation capabilities and API endpoints
Integrate Virtual Microscope with centralized SettingsController and ObjectiveController
Aug 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the Virtual Microscope implementation to integrate properly with ImSwitch's centralized controller architecture, addressing feedback to consolidate duplicate functionality and improve system consistency.
Key Changes Made
Controller Integration
setExposureAndGain()- now handled through SettingsController'ssetDetectorExposureTime()andsetDetectorGain()switchObjective()- now handled through ObjectiveController'smoveToObjective()Enhanced Integration Architecture
_onDetectorSettingChanged()- automatically updates virtual illuminator when exposure/gain changes_onObjectiveChanged()- automatically updates virtual objective binning when objectives switchImproved Stage Drift Simulation
Extended VirtualMicroscopeManager
updateExposureGain()- scales illuminator intensity based on detector settingssetObjective()- controls camera binning to simulate magnification changesUsage Impact
The virtual microscope now responds automatically to standard ImSwitch operations:
Educational and simulation features remain fully functional while integrating seamlessly with ImSwitch's controller ecosystem. This eliminates duplicate API endpoints and ensures consistent behavior across real and virtual hardware.
Fixes #72.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.