feat: Add containers interface to client #704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are right - I wonder how I missed that in https://github.com/openai-php/client/pull/636/files. I now wonder how I can prevent this in future. Like a test that confirms all client methods are indeed part of the contract. |
knash94
changed the title
iBotPeaches
approved these changes
Oct 15, 2025
|
thanks! |
That's a good idea, I'll try thinking of a way to achieve it without being too convoluted for a test 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
Just a trivial change, adding the containers method to the ClientContract as it's not immediately obvious that this library supports containers