[feat] stream annotations as they are added to model response #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiwon-oai
approved these changes
Nov 13, 2025
Comment on lines
+229
to
+232
| # resulting into annotation being a dict or untyped object instead instead of a ResponsesAnnotation | ||
| annotation = TypeAdapter[ResponsesAnnotation](ResponsesAnnotation).validate_python( | ||
| raw_annotation | ||
| ) |
Collaborator
There was a problem hiding this comment.
nit: should we put this in a defensive try except since the validator can throw?
Contributor
Author
There was a problem hiding this comment.
I considered that, but decided maybe an exception is best here.
- It didn't have a try before this change
- This is only operating on objects we got from the responses API so it's a pretty serious contract breakage for this validator not to pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
agents.stream_agent_responseto add annotation parts as they are received rather than adding all the annotations at the end after the response is completed.container_file_citationTest Plan