Move responses mocking helpers to a shared lib #3878
Merged
+141
−131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pact_resume_fork suite Reordered and grouped imports for consistency in test modules. No functional changes.
bolinfest
approved these changes
Sep 18, 2025
| } | ||
|
|
||
| /// Convenience: SSE event for a completed response with a specific id. | ||
| pub fn ev_completed(id: &str) -> Value { |
There was a problem hiding this comment.
Is ev short for event? I guess it's not Electric Vehicle...
I find these names a bit weird. I feel swapping ev_ with create_ or dropping it altogether would be clearer.
There was a problem hiding this comment.
Let's keep it for now because I have another PR based on this. I'll rename later.
pakrym-oai
deleted the
pakrym/move-responses-mocking-helpers-to-a-shared-lib
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are generally useful