Fix nix build #4048
Fix nix build #4048
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
Mic92
force-pushed
the
fix-nix-build
branch
from
93586a6 to
cc08b66
Compare
|
cc @tibo-openai you merged the first pr. |
|
I am planning to include this flake in https://github.com/numtide/nix-ai-tools to monitor if it still builds over time. |
|
I also removed more stuff that was not needed. Check individual commits for details. Overall a nice simplification without loosing any features. |
Mic92
force-pushed
the
fix-nix-build
branch
from
1ce5982 to
917d5f1
Compare
|
cc @bolinfest for review |
|
cc @jif-oai for review |
|
cc @pakrym-oai |
the default.nix for this was removed, so this package is no longer
functional:
% nix build .#packages.aarch64-darwin.codex-cli
error:
… while calling the 'import' builtin
at /nix/store/67mzwrmcffhiagq88zwnigb8npv6lxxv-source/flake.nix:28:21:
27| ];
28| codex-cli = import ./codex-cli {
| ^
29| inherit pkgs monorepo-deps;
error: opening file '/nix/store/67mzwrmcffhiagq88zwnigb8npv6lxxv-source/codex-cli/default.nix': No such file or directory
Signed-off-by: Jörg Thalheim <[email protected]>
also defaultPackage / defaultApps got deprecated by packages.default quite a while ago, which is now dropped. Signed-off-by: Jörg Thalheim <[email protected]>
the previous of nixpkgs was too old to build codex-rs Signed-off-by: Jörg Thalheim <[email protected]>
this is needed because ratatui fetched from git Signed-off-by: Jörg Thalheim <[email protected]>
it was configured but unused.
this flake is simple enough to not need it.
this is just the same as packages in this case, nix run will work also with packages outputs.
The shell alias looks dubious and the shellHook also doesn't work: bash: /nix/store/b010ibix7i333qhv5smcb129yly1dmfj-cargo-setup-hook.sh: Is a directory This devShell is actually not needed. nix develop will just fallback to the package, which has already all dependencies. on the upside we can now use just callPackage which also work better with cross-compilation than the current approach.
|
Thank you! |
3 participants
I dropped the build of the old cli from the flake, where the default.nix already seemed to removed in a previous iterations. Then I updated flake.nix and codex-rs expression to be able to build again (see individual commits for details).
Tested by running the following builds: