Add forced_chatgpt_workspace_id and forced_login_method configuration options #5303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gt-oai
reviewed
Oct 20, 2025
| "refresh_token": "test-refresh-token" | ||
| }, | ||
| "last_refresh": LAST_REFRESH, | ||
| "last_refresh": Utc::now(), |
There was a problem hiding this comment.
Out of curiosity why did this have to change? (It does seem odd it was a const before)
There was a problem hiding this comment.
The test was hitting the refresh oauth token code path and 401ing. We should probably mock it out but this was a simpler fix.
gt-oai
approved these changes
Oct 20, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for configs to specify a forced login method (chatgpt or api) as well as a forced chatgpt account id. This lets enterprises uses managed configs to force all employees to use their company's workspace instead of their own or any other.
When a workspace id is set, a query param is sent to the login flow which auto-selects the given workspace or errors if the user isn't a member of it.
This PR is large but a large % of it is tests, wiring, and required formatting changes.
API login with chatgpt forced
ChatGPT login with api forced
Onboarding with api forced
Onboarding with ChatGPT forced
Logging in with the wrong workspace
