-
Notifications
You must be signed in to change notification settings - Fork 6k
Add ItemStarted/ItemCompleted events for UserInputItem #5306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
df09abe
Add UserItem event
pakrym-oai 529121f
core: move UserInput import, add ItemCollector to TurnContext and emi…
pakrym-oai 8da0400
core: emit ItemStarted and ItemCompleted events for user messages, ad…
pakrym-oai c0c4cfb
Merge branch 'main' into pakrym/add-useritem-event
pakrym-oai 365fd29
Merge branch 'main' into pakrym/add-useritem-event
pakrym-oai 1e9c581
session: pass tx_event to make_turn_context and ItemCollector, update…
pakrym-oai 572ba77
Merge branch 'main' into pakrym/add-useritem-event
pakrym-oai 592e846
Merge branch 'main' into pakrym/add-useritem-event
pakrym-oai 76605cd
protocol: derive JsonSchema for TurnItem, UserMessageItem, ItemStarte…
pakrym-oai 66b4408
tests: fix InputItem to UserInput in auto_compact_triggers_after_func…
pakrym-oai 68a0375
Merge branch 'main' into pakrym/add-useritem-event
pakrym-oai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| use async_channel::Sender; | ||
| use codex_protocol::ConversationId; | ||
| use codex_protocol::items::TurnItem; | ||
| use codex_protocol::protocol::Event; | ||
| use codex_protocol::protocol::EventMsg; | ||
| use codex_protocol::protocol::ItemCompletedEvent; | ||
| use codex_protocol::protocol::ItemStartedEvent; | ||
| use tracing::error; | ||
|
|
||
| #[derive(Debug)] | ||
| pub(crate) struct ItemCollector { | ||
| thread_id: ConversationId, | ||
| turn_id: String, | ||
| tx_event: Sender<Event>, | ||
| } | ||
|
|
||
| impl ItemCollector { | ||
| pub fn new( | ||
| tx_event: Sender<Event>, | ||
| thread_id: ConversationId, | ||
| turn_id: String, | ||
| ) -> ItemCollector { | ||
| ItemCollector { | ||
| tx_event, | ||
| thread_id, | ||
| turn_id, | ||
| } | ||
| } | ||
|
|
||
| pub async fn started(&self, item: TurnItem) { | ||
| let err = self | ||
| .tx_event | ||
| .send(Event { | ||
| id: self.turn_id.clone(), | ||
| msg: EventMsg::ItemStarted(ItemStartedEvent { | ||
| thread_id: self.thread_id, | ||
| turn_id: self.turn_id.clone(), | ||
| item, | ||
| }), | ||
| }) | ||
| .await; | ||
| if let Err(e) = err { | ||
| error!("failed to send item started event: {e}"); | ||
| } | ||
| } | ||
|
|
||
| pub async fn completed(&self, item: TurnItem) { | ||
| let err = self | ||
| .tx_event | ||
| .send(Event { | ||
| id: self.turn_id.clone(), | ||
| msg: EventMsg::ItemCompleted(ItemCompletedEvent { | ||
| thread_id: self.thread_id, | ||
| turn_id: self.turn_id.clone(), | ||
| item, | ||
| }), | ||
| }) | ||
| .await; | ||
| if let Err(e) = err { | ||
| error!("failed to send item completed event: {e}"); | ||
| } | ||
| } | ||
|
|
||
| pub async fn started_completed(&self, item: TurnItem) { | ||
| self.started(item.clone()).await; | ||
| self.completed(item).await; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't pay too much attention to this. I imagine it'll change a lot when we add more interesting items