fix: resume lookup for gitignored CODEX_HOME #5311
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tibo-openai
changed the title
tibo-openai
force-pushed
the
tibo/resume-codex-home
branch
from
a4cf9f5 to
4b569f5
Compare
tibo-openai
force-pushed
the
tibo/resume-codex-home
branch
from
4b569f5 to
68206c5
Compare
pakrym-oai
reviewed
Oct 22, 2025
| .into_iter() | ||
| .next() | ||
| .map(|m| root.join(m.path))) | ||
| let codex_home = codex_home.to_path_buf(); |
There was a problem hiding this comment.
Should we use something like walkdir instead of rolling our own dir walking logic?
pakrym-oai
reviewed
Oct 22, 2025
| let codex_home = codex_home.to_path_buf(); | ||
| let id = id_str.to_owned(); | ||
|
|
||
| spawn_blocking(move || { |
pakrym-oai
reviewed
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Walk the sessions tree instead of using file_search so gitignored CODEX_HOME directories can resume sessions. Add a regression test that covers a .gitignore'd sessions directory.
Fixes #5247
Fixes #5412