Skip to content

Conversation

@tibo-openai
Copy link
Collaborator

@tibo-openai tibo-openai commented Oct 19, 2025

Add shared helper to format warnings when add-dir is incompatible with the sandbox. Surface the warning in the TUI entrypoint and document the limitation for add-dir.

@tibo-openai tibo-openai changed the title Warn when --add-dir is ignored outside workspace-write feat: warn when --add-dir is ignored outside workspace-write Oct 19, 2025
@tibo-openai tibo-openai changed the title feat: warn when --add-dir is ignored outside workspace-write fix: warn when --add-dir is ignored outside workspace-write Oct 19, 2025
@tibo-openai tibo-openai marked this pull request as ready for review October 19, 2025 20:07
@tibo-openai tibo-openai changed the title fix: warn when --add-dir is ignored outside workspace-write fix: error when --add-dir would be ignored Oct 19, 2025
@tibo-openai tibo-openai changed the title fix: error when --add-dir would be ignored fix: warn when --add-dir would be ignored Oct 19, 2025
Copy link
Collaborator

@pakrym-oai pakrym-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use standard mechanism we use for other startup errors (like MCP client failed to start)?

@openai openai deleted a comment from chatgpt-codex-connector bot Oct 20, 2025
@tibo-openai
Copy link
Collaborator Author

The way the error is reported is standard across the file, for example see below (and above)

if let Err(err) = enforce_login_restrictions(&config).await {
  eprintln!("{err}");
  std::process::exit(1);
}

@pakrym-oai
Copy link
Collaborator

Now that you added exit() it is!

@tibo-openai tibo-openai merged commit 8044b55 into main Oct 20, 2025
20 checks passed
@tibo-openai tibo-openai deleted the tibo/add-dir-sandbox-warning branch October 20, 2025 19:08
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants