Skip to content

Conversation

@guidedways
Copy link

Summary

  • teach get_git_diff to gather tracked/untracked diffs for each submodule in parallel, so /review uncommitted changes sees edits inside nested repos
  • skip .gitmodules entries that are not yet initialized worktrees, preventing /review from failing on freshly cloned repos
  • add several regression tests covering both the initialized submodule scenario and the uninitialized placeholder case

Testing

  • just fmt
  • cargo test -p codex-tui

Fixes #5596

@guidedways guidedways changed the title Fix review diff to include submodule changes fix(/review git_diff not considering submodules): Fix review diff to include submodule changes Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

/review at times looks at older, stale (already committed) changes

1 participant