Skip to content

Conversation

@jif-oai
Copy link
Collaborator

@jif-oai jif-oai commented Nov 10, 2025

No description provided.

Copy link
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@etraut-openai etraut-openai added the oai-pr PRs posted by Codex team members label Nov 10, 2025

#[derive(Debug, Clone)]
#[derive(Clone)]
pub struct ModelClient {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally I would like to drop this in the future

otel_event_manager: OtelEventManager,
client: CodexHttpClient,
provider: ModelProviderInfo,
api_client: Arc<OnceCell<RoutedApiClient>>,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo jif

@jif-oai
Copy link
Collaborator Author

jif-oai commented Nov 12, 2025

@codex fix ALL the tests and give a PR where all the tests succeeds

@chatgpt-codex-connector
Copy link
Contributor

Summary

Testing

  • just fmt
  • just fix -p codex-api-client
  • just fix -p codex-core
  • cargo test -p codex-api-client
  • ⚠️ cargo test -p codex-core (fails in exec::tests::kill_child_process_group_kills_grandchildren_on_timeout because the sandbox cannot observe the grandchild exit)

View task →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

oai-pr PRs posted by Codex team members

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants