-
Notifications
You must be signed in to change notification settings - Fork 6.3k
[WIP] chore: client extraction #6457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| #[derive(Debug, Clone)] | ||
| #[derive(Clone)] | ||
| pub struct ModelClient { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally I would like to drop this in the future
| otel_event_manager: OtelEventManager, | ||
| client: CodexHttpClient, | ||
| provider: ModelProviderInfo, | ||
| api_client: Arc<OnceCell<RoutedApiClient>>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo jif
|
@codex fix ALL the tests and give a PR where all the tests succeeds |
|
Summary
Testing
|
No description provided.