feat: execpolicy v2 #6467

zhao-oai · 2025-11-10T18:38:23Z

Summary

Introduces the codex-execpolicy2 crate.
This PR covers only the prefix-rule subset of the planned execpolicy v2 language; a richer language will follow.

Policy

Policy language centers on prefix_rule(pattern=[...], decision?, match?, not_match?), where pattern is an ordered list of tokens; any element may be a list to denote alternatives. decision defaults to allow; valid values are allow, prompt, and forbidden. match / not_match hold example commands that are tokenized and validated at load time (think of these as unit tests).

Policy shapes

Prefix rules use Starlark syntax:

prefix_rule(
    pattern = ["cmd", ["alt1", "alt2"]], # ordered tokens; list entries denote alternatives
    decision = "prompt",                # allow | prompt | forbidden; defaults to allow
    match = [["cmd", "alt1"]],          # examples that must match this rule (enforced at compile time)
    not_match = [["cmd", "oops"]],      # examples that must not match this rule (enforced at compile time)
)

Response shapes

Match:

{
  "match": {
    "decision": "allow|prompt|forbidden",
    "matchedRules": [
      {
        "prefixRuleMatch": {
          "matchedPrefix": ["<token>", "..."],
          "decision": "allow|prompt|forbidden"
        }
      }
    ]
  }
}

No match:

"noMatch"

matchedRules lists every rule whose prefix matched the command; matchedPrefix is the exact prefix that matched.
The effective decision is the strictest severity across all matches (forbidden > prompt > allow).

zhao-oai · 2025-11-10T21:23:44Z

@codex review

chatgpt-codex-connector · 2025-11-10T21:30:08Z

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

zhao-oai · 2025-11-11T00:14:53Z

@codex review

chatgpt-codex-connector · 2025-11-11T00:20:44Z

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

bolinfest

I'm still reviewing, but I have to jump and wanted to share what I saw thus far.

codex-rs/execpolicy2/src/decision.rs

codex-rs/execpolicy2/src/default.policy

codex-rs/execpolicy2/src/default.codexpolicy

codex-rs/execpolicy2/src/main.rs

codex-rs/execpolicy2/src/parser.rs

…ricter_than func

bolinfest

This is a good start, but some things could be tightened up!

codex-rs/execpolicy2/src/main.rs

codex-rs/execpolicy2/src/parser.rs

codex-rs/execpolicy2/README.md

codex-rs/Cargo.toml

codex-rs/execpolicy2/src/default.codexpolicy

codex-rs/execpolicy2/src/policy.rs

zhao-oai · 2025-11-12T02:14:49Z

@codex review

codex-rs/execpolicy2/src/default.codexpolicy

codex-rs/execpolicy2/src/parser.rs

codex-rs/execpolicy2/src/policy.rs

codex-rs/execpolicy2/src/rule.rs

codex-rs/execpolicy2/Cargo.toml

zhao-oai · 2025-11-13T19:30:31Z

@codex review

…t self w/o Mutex

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/execpolicy2/README.md

zhao-oai · 2025-11-13T20:10:58Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2025-11-13T20:18:37Z

codex-rs/execpolicy2/README.md

+  "match": {
+    "decision": "allow|prompt|forbidden",
+    "matched_rules": [
+      {
+        "prefixRuleMatch": {
+          "matched_prefix": ["<token>", "..."],
+          "decision": "allow|prompt|forbidden"
+        }
+      }
+    ]
+  }
+}
+```
+
+- No match:
+```json
+"noMatch"
+```
+
+- `matched_rules` lists every rule whose prefix matched the command; `matched_prefix` is the exact prefix that matched.
+- The effective `decision` is the strictest severity across all matches (`forbidden` > `prompt` > `allow`).


Fix README JSON field names

The response shape documented in README.md shows snake_case fields (matched_rules, matched_prefix) even though the actual serializer derives #[serde(rename_all = "camelCase")] for both Evaluation and RuleMatch (see policy.rs:43-50 and rule.rs:59-66). The CLI/library therefore emits matchedRules and matchedPrefix. Anyone implementing a client using the README will look for the wrong keys and fail to parse the CLI output. Please update the README example and accompanying text to use the camelCase names that the code actually produces.

Useful? React with 👍 / 👎.

@codex could you please compile the code and double check this feedback is correct? if it is correct, please fix the README.md

Summary

Added a serde rename on Evaluation::Match so the CLI now emits matchedRules in camelCase, consistent with the rest of the V2 protocol. codex-rs/execpolicy2/src/policy.rsL43-L51

Ensured RuleMatch serializes its matchedPrefix payload using camelCase so rule details in the response match the documented shape. codex-rs/execpolicy2/src/rule.rsL59-L103

Updated the execpolicy README response example and explanation to describe the camelCase keys the CLI now produces. codex-rs/execpolicy2/README.mdL21-L54

Testing

✅ cargo test -p codex-execpolicy2

✅ cargo run -p codex-execpolicy2 -- check --policy execpolicy2/examples/example.codexpolicy ls -l

View task →

first pass at prefix rules

aa217a7

etraut-openai added the oai-pr PRs posted by Codex team members label Nov 10, 2025

zhao-oai added 2 commits November 10, 2025 11:43

fix cargo shear

f1d71db

update shape of RuleMatch and Evaluation

b738623

zhao-oai added 9 commits November 10, 2025 14:14

remove tokenize_command use cases

db6e305

refactor rules so no more cartesian product

70314f2

simplify logic

8d493f4

simplify

e2f4e60

remove extraneous test

3666b7d

clean up test

f163eab

better default policy + lint

22f7bcb

introduce variant typing to policy result

728887b

README

d17cf35

zhao-oai changed the title ~~[draft] first pass at prefix rules~~ execpolicy v2 Nov 11, 2025

zhao-oai changed the title ~~execpolicy v2~~ feat: execpolicy v2 Nov 11, 2025

update readme

28d3181

bolinfest reviewed Nov 11, 2025

View reviewed changes

zhao-oai added 5 commits November 10, 2025 17:16

use camelCase in Decision'

8c763d6

implementing PartialOrd for Decision instead of defining custom is_st…

59ca84c

…ricter_than func

using clap for execpolicy v2 cli

7d43a4f

add docstrings to decision struct

932fa74

using parking_lot mutex + AtomicU64 for auto id

c1dab29

bolinfest reviewed Nov 11, 2025

View reviewed changes

zhao-oai added 2 commits November 10, 2025 17:55

refactor parse_pattern to use iterator chain

f97cfd2

remove license

5882b43

zhao-oai added 8 commits November 12, 2025 17:40

using PathBufs in main.rs

05e94a4

consolidate new() and parse() in PolicyParser

bc938e5

refactor to test positive matches

26c69af

remove fragile test

70b31ad

docstrings and other cleanup

ffe9973

further cleanup

150cc8d

more cleanup

ffe8049

delete more display()

553d24b

zhao-oai requested a review from bolinfest November 12, 2025 23:59

zhao-oai added 3 commits November 12, 2025 19:00

cleanup

7d67eda

print out actual type in error message

f3dda7a

again, more descriptive error messages

d661900

bolinfest approved these changes Nov 13, 2025

View reviewed changes

zhao-oai added 9 commits November 12, 2025 19:54

sort deps

64b0939

avoid matching on as_slice() when you can use is_empty()

227295f

using expect to provide more context if unwraps fail

f7ec4d2

refactor: rule traits

70c1b03

conslidate validate_match_examples and validate_not_match_examples

fa574bc

move validation logic to rule.rs

e238df8

better naming in Policy.parse()

1d95eb0

directly passing starlark error

a6bf99b

moving default codexpolicy to example

760d57d

now keeping PolicyBuilder in a RefCell, allowing add_rule to take &mu…

8a641fe

…t self w/o Mutex

chatgpt-codex-connector bot reviewed Nov 13, 2025

View reviewed changes

codex-rs/execpolicy2/README.md Show resolved Hide resolved

codex-rs/execpolicy2/README.md Outdated Show resolved Hide resolved

zhao-oai added 2 commits November 13, 2025 14:41

remove use of parking lot

d00caed

update readme

3d8fc22

chatgpt-codex-connector bot reviewed Nov 13, 2025

View reviewed changes

Use camelCase for policy responses

35f3561

feat: execpolicy v2 #6467

Are you sure you want to change the base?

feat: execpolicy v2 #6467

Conversation

zhao-oai commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Policy

Policy shapes

Response shapes

Uh oh!

zhao-oai commented Nov 10, 2025

Uh oh!

chatgpt-codex-connector bot commented Nov 10, 2025

Uh oh!

zhao-oai commented Nov 11, 2025

Uh oh!

chatgpt-codex-connector bot commented Nov 11, 2025

Uh oh!

bolinfest left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bolinfest left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zhao-oai commented Nov 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zhao-oai commented Nov 13, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

zhao-oai commented Nov 13, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

zhao-oai Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot Nov 13, 2025

Choose a reason for hiding this comment

Uh oh!

zhao-oai commented Nov 10, 2025 •

edited

Loading