Feature/sass styles #558
Feature/sass styles #558
Conversation
- Converted CSS styles to SCSS - Broke out styles into components - Added Grunt runner to compile, minimize, and replace style files
- made the path relative to the folder
|
This is great, thanks. For development, it's really wonderful to be able to use the Would you mind removing the grunt portion of this and just adding a rule to build the scss source in the |
|
Or if |
|
I agree, the Gruntfile seems unnecessary. Instead, we can just add a |
- Removed gruntfile in SCSS - Added commands to compiles Sass and Minify Css to the main make file
|
@tilgovi Does this look more like what you had in mind? |
There was a problem hiding this comment.
These look great, but we can add the dependencies and get smart recompiling.
|
I started to comment with specific changes, but it's hard to communicate all the make specifics over comments. Would you be already if I took this into a branch and added some fixups to the Makefile stuff, then you can look it over and try it out before I merge it? |
|
@tilgovi Sure thing! |
|
Took me longer to get back to this than I wanted but I was looking at it today. I've almost got it ready but making this change breaks the browserify bundle that is currently trying to use insert-css. I'm really not a fan of inlining CSS into a JS bundle so I think I'll unbundle that first. Then, I've got the Makefile cleanup ready to go. |
3 participants
Added Sass for styles
Support for Sass is growing. Annotator.js styles should be using the latest best practices in web development. Implementing Sass styles in Annotator will make it easier to integrate with other frameworks and libraries.