Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request upgrades the codebase to Python 3.10+ syntax by replacing the legacy typing.Union and typing.Optional syntax with modern pipe union operators (|), removing the typing-extensions dependency, and updating the minimum Python version requirement from 3.9 to 3.10. It also adds from __future__ import annotations to generated model files to enable forward reference compatibility.
Key changes:
- Replaced
Union[X, Y]withX | YandOptional[X]withX | Nonethroughout the codebase - Updated minimum Python version to 3.10 across all configuration files
- Removed
typing-extensionsdependency - Added
from __future__ import annotationsimport to generated models - Updated union type sorting to use pipe operators with case-insensitive alphabetical ordering
Reviewed Changes
Copilot reviewed 235 out of 239 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updated minimum Python version to 3.10 and removed typing-extensions dependency |
| openapi_python_client/templates/*.jinja | Updated templates to use pipe union syntax and added from __future__ import annotations |
| openapi_python_client/parser/**/*.py | Converted Union/Optional syntax to pipe operators throughout parser code |
| openapi_python_client/schema/**/*.py | Updated OpenAPI schema models to use modern type annotation syntax |
| tests/**/*.py | Updated test files to use pipe operators and removed Union/Optional imports |
| integration-tests/**/*.py | Updated integration test files and generated clients to match new syntax |
| end_to_end_tests/**/*.py | Updated end-to-end test files and golden records with new type annotation syntax |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
520a53e to
dc1bd2a
Compare
dc1bd2a to
9e30953
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.