RT-2.6: IS-IS Interface Hello Padding changes incorporated#5067
RT-2.6: IS-IS Interface Hello Padding changes incorporated#5067ampattan wants to merge 4 commits intoopenconfig:mainfrom
Conversation
Updated metadata.textproto
Added new deviations:
- isis_interface_afi_unsupported
-
- isis_global_authentication_not_required
-
- isis_multi_topology_unsupported
-
- isis_counter_part_changes_unsupported
Updated isis_interface_hello_padding_enable_test.go:
- Added deviation handling for ISIS global authentication
-
- Fixed adjacency verification after MTU modification on ATE
-
- Fixed DIS System ID and Multi-Topology checks
-
- Fixed system-level counter validations to handle missing default values
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
Summary of ChangesHello @ampattan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on enhancing the robustness and adaptability of ISIS interface hello padding tests within the OpenConfig Feature Profiles project. It introduces new deviation flags to account for platform-specific behaviors and refines existing test logic to handle various ISIS configurations and state validations more accurately. The changes aim to improve the reliability of test outcomes by accommodating devices that may not strictly adhere to default OpenConfig models, particularly concerning authentication, adjacency states, and system counters. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Pull Request Functional Test Report for #5067 / 35dd53dVirtual Devices
Hardware Devices
|
Pull Request Test Coverage Report for Build 21984973076Details
💛 - Coveralls |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the IS-IS hello padding test to incorporate several new deviations and improve test robustness. It introduces helper functions to handle the MissingValueForDefaults deviation, which is a good pattern for cleaning up test logic. The changes also add deviation handling for ISIS global authentication and fix adjacency verification logic.
However, I've found a couple of critical issues in the implementation. A new check using check.EqualOrNil is not being executed, effectively skipping a validation. Additionally, a refactoring of the system-level counter checks has introduced bugs where it uses an incorrect validation function and fails to respect existing deviation flags. I've provided suggestions to fix these issues.
...g_tests/isis_interface_hello_padding_enable_test/isis_interface_hello_padding_enable_test.go
Show resolved
Hide resolved
...g_tests/isis_interface_hello_padding_enable_test/isis_interface_hello_padding_enable_test.go
Outdated
Show resolved
Hide resolved
|
@ram-mac Please take a look |
5 participants
Updated metadata.textproto
Added new deviations:
Updated isis_interface_hello_padding_enable_test.go:
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."