RT-1.25: Re-organizing the code to configure and bring up the interface first before assigning it to a network-instance

[pshivash]

Re-organizing the code to configure and bring up the interface first before assigning it to a network-instance on the DUT.
Also, adding the exceptions for Vendor Nokia as expected by the script.
Also, adding the missing subinterface configuration while assigning the interface to a network-instance.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

[gemini-code-assist]

Summary of Changes

Hello @pshivash, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the network interface configuration process within static route tests. The primary goal is to establish a more robust and correct sequence for setting up interfaces on the Device Under Test (DUT), ensuring that interfaces are properly enabled before being associated with a VRF. Additionally, it introduces necessary vendor-specific exceptions for Nokia platforms and addresses a missing subinterface configuration detail, leading to more reliable and compatible test execution.

Highlights

• Interface Configuration Order: The order of operations for configuring and bringing up network interfaces has been re-organized to ensure the interface is configured and enabled before being assigned to a network instance (VRF).
• Nokia Vendor Exceptions: Added specific platform exceptions for the Nokia vendor in the metadata, including interface_enabled and static_protocol_name deviations.
• Subinterface Configuration: Missing subinterface configuration (specifically subinterface 0) has been added when assigning an interface to a network instance, ensuring complete interface setup.

Changelog

• feature/staticroute/tests/static_route_test/metadata.textproto
  • Added a new platform_exceptions block for the NOKIA vendor, specifying deviations for interface_enabled and static_protocol_name.
• feature/staticroute/tests/static_route_test/static_route_test.go
  • Ensured subinterface 0 is explicitly configured when assigning an interface to a network instance in configureInterfaceVRF.
  • Reordered interface configuration in configureDUT to enable the interface first before configuring its VRF assignment.
  • Updated a comment in the TestStaticRouteToDefaultRoute function for clarity.

Activity

• No specific human activity (comments, reviews) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5077 / 9188314

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-1.25: Management network-instance default static route
Cisco 8000E		RT-1.25: Management network-instance default static route
Cisco XRd		RT-1.25: Management network-instance default static route
Juniper ncPTX		RT-1.25: Management network-instance default static route
Nokia SR Linux		RT-1.25: Management network-instance default static route
Openconfig Lemming		RT-1.25: Management network-instance default static route

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-1.25: Management network-instance default static route
Cisco 8808		RT-1.25: Management network-instance default static route
Juniper PTX10008		RT-1.25: Management network-instance default static route
Nokia 7250 IXR-10e		RT-1.25: Management network-instance default static route

Help

[gemini-code-assist]

Code Review

This pull request correctly refactors the DUT configuration logic to enable interfaces before assigning them to a network instance, a necessary change for some vendor platforms. It also adds the missing subinterface index when associating an interface with a VRF and includes new platform exceptions for Nokia. The changes are logical and improve test compatibility. I have added one suggestion to refactor duplicated code into a loop, which improves maintainability and aligns with the repository's style guide.

[coveralls]

Pull Request Test Coverage Report for Build 21899994891

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 10.114%

---

Totals
Change from base Build 21894460486:	0.0%
Covered Lines:	2300
Relevant Lines:	22741

---

💛 - Coveralls

[nsadhasivam]

@rohit-rp Please take a look