modifications to RT-10.2: Non-default Route Generation based on 192.168.2.2/32 Presence in ISIS

[divyarema]

• Added deviations isis_level_enabled and interface_ref_interface_id_format
• Added agreggate route configs.

[OpenConfigBot]

Pull Request Functional Test Report for #5078 / 9132113

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-10.2: Non-default Route Generation based on 192.168.2.2/32 Presence in ISIS
Cisco 8000E		RT-10.2: Non-default Route Generation based on 192.168.2.2/32 Presence in ISIS
Cisco XRd		RT-10.2: Non-default Route Generation based on 192.168.2.2/32 Presence in ISIS
Juniper ncPTX		RT-10.2: Non-default Route Generation based on 192.168.2.2/32 Presence in ISIS
Nokia SR Linux		RT-10.2: Non-default Route Generation based on 192.168.2.2/32 Presence in ISIS
Openconfig Lemming		RT-10.2: Non-default Route Generation based on 192.168.2.2/32 Presence in ISIS

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-10.2: Non-default Route Generation based on 192.168.2.2/32 Presence in ISIS
Cisco 8808		RT-10.2: Non-default Route Generation based on 192.168.2.2/32 Presence in ISIS
Juniper PTX10008		RT-10.2: Non-default Route Generation based on 192.168.2.2/32 Presence in ISIS
Nokia 7250 IXR-10e		RT-10.2: Non-default Route Generation based on 192.168.2.2/32 Presence in ISIS

Help

[gemini-code-assist]

Summary of Changes

Hello @divyarema, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces modifications to the ISIS configuration and dynamic route generation logic. It incorporates platform-specific deviations for Juniper devices and adds functionality for configuring aggregate routes. The changes enhance the flexibility and control over route advertisement within the ISIS protocol, particularly in scenarios requiring non-default route generation.

Highlights

• Deviations: Added deviations for isis_level_enabled and interface_ref_interface_id_format to handle platform-specific configurations, particularly for Juniper devices.
• Aggregate Route Configuration: Introduced configurations for aggregate routes, allowing for the creation and management of summarized routes within the ISIS protocol.
• Dynamic Route Generation: Modified the GenerateDynamicRouteWithISIS function to support the configuration of local aggregate routes, enabling dynamic route generation based on ISIS triggers.

Activity

• Added deviations isis_level_enabled and interface_ref_interface_id_format
• Added aggregate route configs.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request modifies the generate_route test to support route generation on Juniper devices by adding new deviations (isis_level_enabled, interface_ref_interface_id_format) and implementing the corresponding logic. The changes also refactor the GenerateDynamicRouteWithISIS helper to configure aggregate routes using OpenConfig for the default case.

My review focuses on improving the new implementation in internal/cfgplugins/isis.go. I've pointed out some redundant code that can be simplified for better readability and maintainability. I also noted that a function signature deviates from the repository's cfgplugins guidelines by including an unused batch parameter and performing immediate configuration, and I've suggested a correction, while also considering the rule about maintaining consistency.

[coveralls]

Pull Request Test Coverage Report for Build 21908500386

Details

• 0 of 17 (0.0%) changed or added relevant lines in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage decreased (-0.007%) to 10.107%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
internal/cfgplugins/isis.go	0	17	0.0%

Totals
Change from base Build 21894460486:	-0.007%
Covered Lines:	2300
Relevant Lines:	22756

---

💛 - Coveralls