Added removable components check to telemetry_inventory_test

[chitadi]

The removable components of this test were not being semantically validated. This check has been added.

[gemini-code-assist]

Summary of Changes

Hello @chitadi, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the telemetry inventory tests by introducing a new validation for the Removable property of various hardware components. It ensures that the Removable field is properly set for relevant component types, thereby improving the semantic correctness and robustness of the inventory data validation.

Highlights

• New Test for Removable Components: A new test, TestRemovableComponents, has been added to validate the Removable field for various component types, ensuring semantic validation for these components.
• Expanded Component Type Support: The componentType map in telemetry_inventory_test.go was updated to include FRU (Field Replaceable Unit) and Port types, enhancing the test's coverage.
• Documentation Update: The README.md file was updated to reflect the added FRU and Port platform types for the /components/component/state/removable path, aligning documentation with code changes.

Changelog

• feature/platform/tests/telemetry_inventory_test/README.md
  • Included 'FRU' and 'Port' in the platform_type list for /components/component/state/removable.
• feature/platform/tests/telemetry_inventory_test/telemetry_inventory_test.go
  • Expanded the componentType map to include FRU and Port.
  • Implemented TestRemovableComponents to verify that the Removable field is not nil for specified component types.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5087 / 3ba2d3d

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		gNMI-1.4: Telemetry: Inventory	c8fb7b93	Log
Cisco 8000E		gNMI-1.4: Telemetry: Inventory	198ad5ef	Log
Cisco XRd		gNMI-1.4: Telemetry: Inventory	415c463a	Log
Juniper ncPTX		gNMI-1.4: Telemetry: Inventory	b0b3893f	Log
Nokia SR Linux		gNMI-1.4: Telemetry: Inventory	9896fb75	Log
Openconfig Lemming		gNMI-1.4: Telemetry: Inventory	3e2cde5d	Log

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		gNMI-1.4: Telemetry: Inventory
Cisco 8808		gNMI-1.4: Telemetry: Inventory
Juniper PTX10008		gNMI-1.4: Telemetry: Inventory
Nokia 7250 IXR-10e		gNMI-1.4: Telemetry: Inventory

Help

[gemini-code-assist]

Code Review

This pull request adds a new test to validate the removable state for various hardware components, along with corresponding updates to the componentType map and the test's README.md. The changes are logical and address the goal of enhancing semantic validation. The suggested improvement to the new test function to make it more efficient by avoiding nested loops has been kept as it does not contradict any existing rules and provides a valid performance optimization.

[coveralls]

Pull Request Test Coverage Report for Build 22092074901

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 10.091%

---

Totals
Change from base Build 22089223689:	0.0%
Covered Lines:	2300
Relevant Lines:	22792

---

💛 - Coveralls