Fix config issue for interfaces not configured correctly in TE-17.1

[AishwaryaSKulakrni]

• Populated interface-ref with base interface and subinterface index when interface name contains a dot notation.
• Added check for InterfaceRefConfigUnsupported deviation to handle devices that don't support interface-ref config.
• Ensured ISIS interface configuration properly parses interface names and sub-interface indices.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello @AishwaryaSKulakrni, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a configuration issue in TE-17.1 where ISIS interfaces were not correctly configured, particularly concerning interface-ref fields. The changes ensure that interface names with dot notation are properly parsed to extract base interfaces and subinterface indices, and also introduce a mechanism to handle devices that do not support interface-ref configuration.

Highlights

• Interface-ref population: Populated interface-ref with base interface and subinterface index when interface names contain dot notation.
• Deviation handling: Added a check for InterfaceRefConfigUnsupported deviation to manage devices that do not support interface-ref configuration.
• ISIS interface parsing: Ensured ISIS interface configuration correctly parses interface names and sub-interface indices.

Changelog

• feature/gribi/otg_tests/vrf_policy_driven_te/vrf_policy_driven_te_test.go
  • Imported the 'strings' package.
  • Implemented logic to extract base interface and subinterface index from interface names with dot notation and populate the 'interface-ref' field.
  • Added a conditional check to set 'InterfaceRef' to 'nil' if the device does not support 'interface-ref' configuration.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5092 / 3c9ff2a

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		TE-17.1: VRF selection policy driven TE
Cisco 8000E		TE-17.1: VRF selection policy driven TE
Cisco XRd		TE-17.1: VRF selection policy driven TE
Juniper ncPTX		TE-17.1: VRF selection policy driven TE
Nokia SR Linux		TE-17.1: VRF selection policy driven TE
Openconfig Lemming		TE-17.1: VRF selection policy driven TE

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		TE-17.1: VRF selection policy driven TE
Cisco 8808		TE-17.1: VRF selection policy driven TE
Juniper PTX10008		TE-17.1: VRF selection policy driven TE
Nokia 7250 IXR-10e		TE-17.1: VRF selection policy driven TE

Help

[gemini-code-assist]

Code Review

The pull request correctly addresses the configuration issue for ISIS interfaces by populating the interface-ref and handling the InterfaceRefConfigUnsupported deviation. I've suggested a refactoring to ensure interface-ref is consistently populated even when the interface name does not contain a dot notation, which aligns better with the intent described in the code comments and ensures broader platform compatibility, adhering to the principle of maintaining consistent and robust code patterns.