RT-1.54 update

[sachendras]

Following updates

1. Added RT-1.54.5
2. Added canonical OC
3. Updated the topology diagram

[gemini-code-assist]

Summary of Changes

Hello @sachendras, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the documentation for the BGP override AS-path split-horizon test. It introduces a new test scenario (RT-1.54.5) focusing on the allow-own-as configuration, provides a clear OpenConfig JSON example for this setting, and improves the visual representation of the test topology using a Mermaid diagram.

Highlights

• New Test Case: Added a new test case, RT-1.54.5, to validate the "DUTs AS as Originating AS" functionality within the BGP override AS-path split-horizon test.
• Canonical OpenConfig: Included a canonical OpenConfig JSON example to illustrate the configuration for "allow-own-as" within BGP peer groups.
• Topology Diagram Update: Updated the test topology diagram in the README to a more visual and structured Mermaid format.

Changelog

• feature/bgp/otg_tests/bgp_override_as_path_split_horizon_test/README.md
  • Updated the topology section to use a Mermaid diagram for better visualization.
  • Added a new test case description for RT-1.54.5, covering the "DUTs AS as Originating AS" scenario.
  • Included a canonical OpenConfig JSON snippet for BGP allow-own-as configuration.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5104 / 0393ea4

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		RT-1.54: BGP Override AS-path split-horizon	92acd03f	Log
Cisco 8000E		RT-1.54: BGP Override AS-path split-horizon	bf98decf	Log
Cisco XRd		RT-1.54: BGP Override AS-path split-horizon	54a61e20	Log
Juniper ncPTX		RT-1.54: BGP Override AS-path split-horizon	257bb4f3	Log
Nokia SR Linux		RT-1.54: BGP Override AS-path split-horizon	15dbcd5c	Log
Openconfig Lemming		RT-1.54: BGP Override AS-path split-horizon	48c01e35	Log

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		RT-1.54: BGP Override AS-path split-horizon
Cisco 8808		RT-1.54: BGP Override AS-path split-horizon
Juniper PTX10008		RT-1.54: BGP Override AS-path split-horizon
Nokia 7250 IXR-10e		RT-1.54: BGP Override AS-path split-horizon

Help

[gemini-code-assist]

Code Review

This pull request updates the README.md for the bgp_override_as_path_split_horizon_test. The changes include improving the topology diagram using mermaid syntax and adding a canonical OpenConfig example, which are positive changes for documentation clarity. However, a new test case, RT-1.54.5, has been added to the documentation but is not implemented in the test code. This is a significant omission that needs to be addressed. I've also pointed out a minor typo in the new test case description.

[ram-mac]

LGTM, Approving