Conversation
Summary of ChangesHello @ram-mac, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the test registry by incorporating a new test case related to ISIS node-SID forwarding and revising an existing test's identifier for static LSP forwarding. These changes ensure the registry accurately reflects the current set of available tests and their correct references. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request updates the test registry by adding the SR-1.1 test and renaming TE-9.2 to PF-1.25. The addition of SR-1.1 is correctly placed and matches its documentation, though it is missing the exec field. However, the PF-1.25 entry is out of alphabetical order and introduces inconsistencies with the linked README and metadata files, which still refer to the old TE-9.2 ID and a different test description.
testregistry.textproto
Outdated
| id: "PF-1.25" | ||
| description: "MPLS based forwarding Static LSP" | ||
| readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/gribi/otg_tests/mpls_compliance/README.md" |
There was a problem hiding this comment.
Renaming TE-9.2 to PF-1.25 creates an inconsistency with the linked README (feature/gribi/otg_tests/mpls_compliance/README.md) which still uses TE-9.2, and the metadata.textproto which uses TE-9. Furthermore, the description "MPLS based forwarding Static LSP" does not match the title in the README ("Push MPLS Labels to IP Packet"). Please update the test files to match the new ID and description to ensure the registry remains a reliable source of truth.
testregistry.textproto
Outdated
| } | ||
| test: { | ||
| id: "TE-9.2" | ||
| id: "PF-1.25" |
Adding SR-1.1
Updating the test registry for static_lsp test plan ID from TE-9.2 to PF-1.25