Skip to content

Update test registry#5119

Closed
ram-mac wants to merge 4 commits intoopenconfig:mainfrom
ram-mac:testregistry
Closed

Update test registry#5119
ram-mac wants to merge 4 commits intoopenconfig:mainfrom
ram-mac:testregistry

Conversation

@ram-mac
Copy link
Contributor

@ram-mac ram-mac commented Feb 23, 2026

Adding SR-1.1
Updating the test registry for static_lsp test plan ID from TE-9.2 to PF-1.25

@ram-mac ram-mac requested a review from a team as a code owner February 23, 2026 04:57
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ram-mac, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the test registry by incorporating a new test case related to ISIS node-SID forwarding and revising an existing test's identifier for static LSP forwarding. These changes ensure the registry accurately reflects the current set of available tests and their correct references.

Highlights

  • New Test Entry Added: A new test with ID 'SR-1.1' for 'Transit forwarding to Node-SID via ISIS' has been added to the test registry.
  • Test ID Updated: The test ID for 'MPLS based forwarding Static LSP' has been updated from 'TE-9.2' to 'PF-1.25'.
  • File Formatting Fix: A missing newline character at the end of the 'testregistry.textproto' file has been added.
Changelog
  • testregistry.textproto
    • Added a new test entry for 'SR-1.1' (Transit forwarding to Node-SID via ISIS).
    • Updated the test ID for 'MPLS based forwarding Static LSP' from 'TE-9.2' to 'PF-1.25'.
    • Resolved a formatting issue by adding a newline at the end of the file.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@OpenConfigBot
Copy link

OpenConfigBot commented Feb 23, 2026

Pull Request Functional Test Report for #5119 / 61b6c6e

No tests identified for validation.

Help

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the test registry by adding the SR-1.1 test and renaming TE-9.2 to PF-1.25. The addition of SR-1.1 is correctly placed and matches its documentation, though it is missing the exec field. However, the PF-1.25 entry is out of alphabetical order and introduces inconsistencies with the linked README and metadata files, which still refer to the old TE-9.2 ID and a different test description.

Comment on lines 1537 to 1539
id: "PF-1.25"
description: "MPLS based forwarding Static LSP"
readme: "https://github.com/openconfig/featureprofiles/blob/main/feature/gribi/otg_tests/mpls_compliance/README.md"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Renaming TE-9.2 to PF-1.25 creates an inconsistency with the linked README (feature/gribi/otg_tests/mpls_compliance/README.md) which still uses TE-9.2, and the metadata.textproto which uses TE-9. Furthermore, the description "MPLS based forwarding Static LSP" does not match the title in the README ("Push MPLS Labels to IP Packet"). Please update the test files to match the new ID and description to ensure the registry remains a reliable source of truth.

}
test: {
id: "TE-9.2"
id: "PF-1.25"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The test ID PF-1.25 is out of alphabetical order. To maintain the organization of the registry, it should be moved to the PF section (after PF-1.23, around line 631).

@ram-mac ram-mac closed this Mar 2, 2026
@ram-mac ram-mac deleted the testregistry branch March 2, 2026 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants